Updating readme for running ibex with riscv-compliance #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haseebazaz-10xe
commented
Jul 26, 2021
haseebazaz-10xe
commented
- While running ibex with riscv-compliance a package was necessary in Ubuntu.
- Also as riscv-compliance repository name has been updated so it is better to update it in README too. I know it redirects you to new repository but I think its better that repository should be updated here too.
- Targets in case of riscv-compliance are I, M, C, Zifencei etc instead of rv32imc.
imphil
suggested changes
Aug 31, 2021
There was a problem hiding this comment.
Thanks for your pull request @haseebazaz-10xe! I have a couple comments, could you please have a look at them?
| @@ -62,7 +63,7 @@ How to run RISC-V Compliance on Ibex | |||
| # give the absolute path to the simulation binary compiled in step 1 | |||
| export TARGET_SIM=/path/to/your/Vibex_riscv_compliance | |||
|
|
|||
| export RISCV_DEVICE=rv32imc | |||
| export RISCV_DEVICE=I # Other targets for compliance can be C & M | |||
There was a problem hiding this comment.
Just to confirm: IMC is not a valid option anymore?
There was a problem hiding this comment.
Yes. Targets in riscv-compliance have changed from rv32imc to I, M, C, Zifencei etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.