[rvfi] Only catch LSU RF write data if it's actually valid #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogelpi
requested review from
andreaskurth,
GregAC and
hcallahan-lowrisc
and removed request for
andreaskurth
GregAC
force-pushed
the
rvfi-sample-valid-lsu-data-only
branch
from
c23e295
to
e37e673
Compare
GregAC
approved these changes
Apr 21, 2023
hcallahan-lowrisc
approved these changes
May 26, 2023
Previously, the interface was also catching the data returned by stores which may be X. Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
vogelpi
force-pushed
the
rvfi-sample-valid-lsu-data-only
branch
from
e37e673
to
f4ed142
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the interface was also catching the data returned by stores which may be X.