Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ZiCond(Conditional move) #2046

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

asimahsan1990
Copy link

Add support for the Zicond extension added v1.0-rc. The new instructions added are:

  • czero.eqz
  • czero.nez

@asimahsan1990 asimahsan1990 marked this pull request as draft June 12, 2023 10:35
@asimahsan1990 asimahsan1990 marked this pull request as ready for review June 12, 2023 11:06
@asimahsan1990
Copy link
Author

@GregAC

@GregAC
Copy link
Collaborator

GregAC commented Jul 13, 2023

Thanks for the contribution @asimahsan1990, though unfortunately we can't accept this PR as it stands.

The RTL implementation itself looks reasonable but we need to add DV for it and also consider how it can be parametrised, as typically new features and extensions are optional, rather than a mandatory part of the base RTL. We also need to ensure we have at least assembly support in the lowRISC toolchain.

That second point in particular is tricky as I think we need to develop a new strategy here as we're getting more and more parameters and I think we need to look at new approaches especially if we're adding more small extensions like this.

However I'll leave this open so it's something that can be picked up by interested parties.

@quswarabid
Copy link

I think there is no support for RISCV-DV for ZiCond ext. yet.

@asimahsan1990 maybe you need to get that added first AFAIK since Ibex uses that in its verification environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants