Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Show images in Blog Post List #34

Merged
merged 4 commits into from
Nov 15, 2019
Merged

Show images in Blog Post List #34

merged 4 commits into from
Nov 15, 2019

Conversation

lenary
Copy link
Contributor

@lenary lenary commented Nov 5, 2019

Closes #28

@lenary lenary force-pushed the lenary/image-blog-list branch 2 times, most recently from 93d94cb to 66c4d8b Compare November 5, 2019 13:34
@lenary lenary force-pushed the lenary/image-blog-list branch from 66c4d8b to f92e3e2 Compare November 6, 2019 14:41
Copy link
Contributor Author

@lenary lenary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some notes on the added metadata.

@@ -3,6 +3,17 @@ Description = ""
date = "2019-06-10T15:00:00+01:00"
title = "An update on Ibex, our microcontroller-class CPU core"
author = "Philipp Wagner"

featured_image = "Ibex_block_diagram-100619.png"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the metadata to point at the image to use on the blog list page.

Comment on lines +9 to +11
[[resources]]
src = "Ibex_block_diagram-100619.png"
title = "Ibex block diagram"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is per-image metadata to override the default resource title (which is good practice). We use this title in the blog post listing.

@@ -3,6 +3,19 @@ Description = ""
date = "2019-10-08T16:30:00+01:00"
title = "Ibex on FPGA - Get stuff executed"
author = "Pirmin Vogel"

featured_image = "Ibex_on_Nexys_Video.jpg"
images = ["Ibex_on_Nexys_Video.jpg", "PULPissimo_on_Nexys_Video.png"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This metadata is not used yet, but is good to set (it will likely be used when I start doing opengraph/twitter card stuff)

Copy link
Contributor

@imphil imphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've opened #39 to use the title in the img shortcode by default, so that we don't need to specify it twice.

@imphil imphil merged commit 5b26f8e into master Nov 15, 2019
@imphil imphil deleted the lenary/image-blog-list branch November 15, 2019 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add images to blog previews
2 participants