Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rom_ext] Ensure internal pull-up attach to UART_RX when sampling for UART BREAK for rescue #24551

Open
jettr opened this issue Sep 11, 2024 · 0 comments
Open

[rom_ext] Ensure internal pull-up attach to UART_RX when sampling for UART BREAK for rescue #24551

jettr opened this issue Sep 11, 2024 · 0 comments
Assignees
@cfrantz
Labels
SW:ROM_EXT ROM_EXT related issues

Comments

@jettr
Copy link
Contributor

jettr commented Sep 11, 2024

Description

We want to ensure that a floating UART_RX pin will not falsely trigger the UART break condition on the chip while ROM_EXT is sampling UART to know whether to enter rescue mode or not.
@jettr jettr added the SW:ROM_EXT ROM_EXT related issues label Sep 11, 2024
cfrantz added a commit to cfrantz/opentitan that referenced this issue Sep 11, 2024
@cfrantz
[rom, rom_ext] Enable pull-up on UART_RX
6ca7587 
Fixes: lowRISC#24551

Signed-off-by: Chris Frantz <cfrantz@google.com>
@cfrantz cfrantz mentioned this issue Sep 11, 2024
Merged
cfrantz added a commit that referenced this issue Sep 11, 2024
@cfrantz
[rom, rom_ext] Enable pull-up on UART_RX
96f0ca8 
Fixes: #24551

Signed-off-by: Chris Frantz <cfrantz@google.com>
github-actions bot pushed a commit that referenced this issue Sep 11, 2024
@cfrantz @github-actions
[rom, rom_ext] Enable pull-up on UART_RX
65db5f0 
Fixes: #24551

Signed-off-by: Chris Frantz <cfrantz@google.com>
(cherry picked from commit 6ca7587)
github-actions bot pushed a commit that referenced this issue Oct 28, 2024
@cfrantz @github-actions
[rom, rom_ext] Enable pull-up on UART_RX
c7b32bc 
Fixes: #24551

Signed-off-by: Chris Frantz <cfrantz@google.com>
(cherry picked from commit 6ca7587)
cfrantz added a commit that referenced this issue Oct 28, 2024
@cfrantz
[rom, rom_ext] Enable pull-up on UART_RX
e854f9f 
Fixes: #24551

Signed-off-by: Chris Frantz <cfrantz@google.com>
(cherry picked from commit 6ca7587)
cfrantz added a commit that referenced this issue Oct 29, 2024
@cfrantz
[rom, rom_ext] Enable pull-up on UART_RX
722e71b 
Fixes: #24551

Signed-off-by: Chris Frantz <cfrantz@google.com>
(cherry picked from commit 6ca7587)
moidx pushed a commit that referenced this issue Oct 29, 2024
@cfrantz @moidx
[rom, rom_ext] Enable pull-up on UART_RX
87b6880 
Fixes: #24551

Signed-off-by: Chris Frantz <cfrantz@google.com>
(cherry picked from commit 6ca7587)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cfrantz cfrantz

Labels
SW:ROM_EXT ROM_EXT related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cfrantz @jettr