[rom_ext_e2e] More ownership transfer tests #24479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfrantz
changed the title
The tests added by this change are all simple variations on the ownership transfer test added in lowRISC#24419. They involve verifying the different modes and error conditions (e.g. using the wrong key). Adds the following tests: - `bad_unlock_test`; Fixes lowRISC#24466 - `bad_activate_test`; Fixes lowRISC#24467 - `bad_owner_block_test`; Fixes lowRISC#24468 - `bad_app_key_test`; Fixes lowRISC#24469 - `transfer_endorsed_test`; Fixes lowRISC#24470 - `bad_endorsee_test`; Fixes lowRISC#24471 - `locked_update_test`; Fixes lowRISC#24472 - `bad_locked_update_test` & `bad_locked_update_no_exec_test`; Fixes lowRISC#24473 Signed-off-by: Chris Frantz <cfrantz@google.com>
cfrantz
force-pushed
the
owner-init-tests2
branch
from
1f21fd3
to
4d520bd
Compare
moidx
approved these changes
Sep 3, 2024
| name, | ||
| srcs = ["//sw/device/silicon_creator/rom_ext/e2e/verified_boot:boot_test"], | ||
| exec_env = { | ||
| "//hw/top_earlgrey:fpga_cw310_rom_ext": None, |
There was a problem hiding this comment.
nit: It would also be nice to also support the cw340 target.
//hw/top_earlgrey:fpga_cw340_rom_ext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests added by this change are all simple variations on
the ownership transfer test added in #24419. They involve verifying the
different modes and error conditions (e.g. using the wrong key).
Adds the following tests:
bad_unlock_test; Fixes Verify that ROM_EXT rejects an OwnershipUnlock operation with the wrong key. #24466bad_activate_test; Fixes Verify that ROM_EXT rejects an OwnershipActivate operation with the wrong key. #24467bad_owner_block_test; Fixes Verify that ROM_EXT rejects a bad ownership configuration. #24468bad_app_key_test; Fixes Verify that ROM_EXT will not execute code signed with the wrong key. #24469transfer_endorsed_test; Fixes Verify that ROM_EXT can unlock and transfer ownership to a specific owner. #24470bad_endorsee_test; Fixes Verify that ROM_EXT rejects ownership transfer to a non-endorsed owner. #24471locked_update_test; Fixes Verify that ROM_EXT accepts an owner configuration update. #24472bad_locked_update_test&bad_locked_update_no_exec_test; Fixes Verify that ROM_EXT rejects an owner configuration update. #24473Note: This PR# depends on #24419; you need only review the last commit.