Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Migrate all source repositories (non-Bazel aware) to bzlmod #25714

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jwnrt
Copy link
Contributor

@jwnrt jwnrt commented Dec 19, 2024

  • Remove two unused dependencies from WORKSPACE.bzlmod that should have been dropped in previous PRs but were missed.
  • Fix #include "external/..." paths to included directories.
  • Make _repos() functions private, run them from extensions, and extract repos.
  • Move patch files into a patches subdirectory to match existing third_party convention.

The verible syntax python file here is used directly within our Bazel
repository, not through its own repository. Removed.

The `lowrisc_misc_linters` repository should have been removed when it
was migrated to Bzlmod.

Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
This was a transitive dependency of Buildifier that should have been
removed when that was migrated to Bzlmod.

Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
@jwnrt jwnrt requested a review from cfrantz as a code owner December 19, 2024 16:20
@jwnrt jwnrt marked this pull request as draft December 19, 2024 16:20
@jwnrt jwnrt force-pushed the bzlmod-misc-repos branch 2 times, most recently from b47c6d4 to bee8bc1 Compare December 19, 2024 16:52
These paths are not stable and should not be hard coded. Files must
use the path relative to `includes = [...]` parameters added to
`cc_library` rules. These paths change under bzlmod.

Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
These repositories are not Bazel-aware, we're only using them for their
sources. Each dependency's `_repos()` function is made private and run
from a bzlmod extension which is called from `MODULE.bazel` and the
repositories are brought into the module's namespace.

Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
This matches the convention of other third party packages with patches.

Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
This is no longer used / usable with Bzlmod. Use `override_repo` in the
`MODULE.bazel` instead.

Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
@jwnrt jwnrt force-pushed the bzlmod-misc-repos branch from b3481bd to a5c4ee5 Compare December 19, 2024 17:00
@jwnrt jwnrt requested review from pamaury and nbdd0121 December 19, 2024 17:15
@jwnrt jwnrt marked this pull request as ready for review December 19, 2024 17:16
@jwnrt jwnrt requested a review from a team as a code owner December 19, 2024 17:16
@jwnrt jwnrt mentioned this pull request Dec 19, 2024
17 tasks
@moidx moidx removed the request for review from a team December 20, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant