ot_aes: Do not check input/key validity in manual mode #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/lowRISC/opentitan/blob/83b8114beceb0685b8b2a7ef7e0274aa2a8393ae/hw/ip/aes/rtl/aes_control_fsm.sv#L194-L216 Fixes behaviour of the AES when operating in manual mode - the presence of input data via the FIFO and the validity of the (sideloaded) key is not checked when performing a manual AES operation. These conditions are only checked when operating in automatic mode. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
rivos-eblot
approved these changes
Sep 10, 2025
No worries, sorry for the recent flood of PRs 😅 @jwnrt if you get a chance, could you check this? |
jwnrt
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes behaviour of the AES when operating in manual mode - the presence of input data via the FIFO and the validity of the (sideloaded) key is not checked when performing a manual AES operation. These conditions are only checked when operating in automatic mode.
See relevant RTL: https://github.com/lowRISC/opentitan/blob/83b8114beceb0685b8b2a7ef7e0274aa2a8393ae/hw/ip/aes/rtl/aes_control_fsm.sv#L192-L216
Also see relevant SW test (clears the keymgr sideload key, invalidating it, and then expects a manual mode AES operation to throw no errors): https://github.com/lowRISC/opentitan/blob/df2110dc5caa7df2856747dae886a2ed50208570/sw/device/tests/keymgr_sideload_aes_test.c#L154-L169