ot_lc_ctrl: Fix HW_CFG load memcpy size calculation
#214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rivos-eblot
approved these changes
Oct 3, 2025
Yes, I will add that to this PR. Edit: Pushed that now. Not sure if there is a cleaner way to do this, feedback welcome :) |
AlexJones0
force-pushed
the
hw_cfg_copy
branch
2 times, most recently
from
d0405da to
8a1a937
Compare
ziuziakowska
approved these changes
Oct 6, 2025
rivos-eblot
reviewed
Oct 6, 2025
As we use this idiom in several files, it might be worth to define something like: #define OT_REG_NAME_IDX(_n_, _i_) (R_ ## _n_ ## _ ## _i_)
#define OT_REG_COUNT(_n_, _l_) (OT_REG_NAME_IDX(_n_, _l_) - OT_REG_NAME_IDX(_n_, 0) + 1u)
#define OT_REG_SPAN(_n_, _l_) (OT_REG_COUNT(_n_, _l_) * sizeof(uint32_t))
// example
#define LC_MANUF_STATE_WIDTH OT_REG_SPAN(MANUF_STATE, 7)
#define LC_DEVICE_ID_WIDTH OT_REG_SPAN(DEVICE_ID, 7)in |
Adds macros for generic computing of the size of register spans for OpenTitan multi registers, which can be used to e.g. make static assertions to ensure that the size of macros matches the size of buffers being used. Co-authored-by: Emmanuel Blot <eblot@rivosinc.com> Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
These `memcpy`s were accidentally using the size of the dereferenced byte array (i.e., always just 1 byte), and so were only copying the first byte of the HW_CFG device ID and manufacturing state that were being loaded from the OTP. Also add some local calculations and static assertions to check that the HW_CFG value sizes that are given do not become out of sync with the size of the registers. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
AlexJones0
force-pushed
the
hw_cfg_copy
branch
from
8a1a937 to
f8469a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These
memcpys were accidentally using the size of the dereferenced byte array (i.e., always just 1 byte), and so were only copying the first byte of the HW_CFG device ID and manufacturing state that were being loaded from the OTP.