[ot] scripts/opentitan: add a GDB replay script from QEMU exec log #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loiclefort
reviewed
Nov 27, 2023
docs/opentitan/gdbreplay.md
Outdated
|
|
||
| ### Arguments | ||
|
|
||
| * `-a` specify an address where to load the matching RAW binary application, see `-b` optiion for |
There was a problem hiding this comment.
Suggested change
| * `-a` specify an address where to load the matching RAW binary application, see `-b` optiion for | |
| * `-a` specify an address where to load the matching RAW binary application, see `-b` option for |
scripts/opentitan/gdbreplay.py
Outdated
| except ELFError as exc: | ||
| raise ValueError(f'Invalid ELF file: {exc}') from exc | ||
| if self._elf['e_machine'] != 'EM_RISCV': | ||
| raise ValueError('Not an RISC-V ELF file') |
There was a problem hiding this comment.
Suggested change
| raise ValueError('Not an RISC-V ELF file') | |
| raise ValueError('Not a RISC-V ELF file') |
scripts/opentitan/gdbreplay.py
Outdated
|
|
||
| @property | ||
| def raw_size(self) -> int: | ||
| """Provide the size of the Secure Boot Header section, if any. |
There was a problem hiding this comment.
Suggested change
| """Provide the size of the Secure Boot Header section, if any. | |
| """Provide the size of the payload, if any. |
| raise ValueError('No loadable segment found') | ||
| return phy_start, size | ||
|
|
||
| def _build_payload(self) -> bytes: |
There was a problem hiding this comment.
_parse_segments and _build_payload look very similar, maybe factorize common code?
There was a problem hiding this comment.
We do not want to build the full object in RAM when we only need to compute the final size.
scripts/opentitan/gdbreplay.py
Outdated
|
|
||
| def cont(self, back: bool = False, addr: Optional[int] = None) -> bool: | ||
| """Continue execution of instruction stream till either a HW breakpoint | ||
| or the end of the execution streamed is reached. |
There was a problem hiding this comment.
Suggested change
| or the end of the execution streamed is reached. | |
| or the end of the execution stream is reached. |
scripts/opentitan/gdbreplay.py
Outdated
| xpc = int(spc, 16) | ||
| if not lno % 10000: | ||
| self._log.debug('Parsed %d lines', lno) | ||
| #self._log.debug("0x%08x %s", xpc, func) |
scripts/opentitan/gdbreplay.py
Outdated
| crc = int(buf[end+1:end+3], 16) | ||
| buf = req[end+3:] | ||
| # if start != 0: | ||
| # continue |
scripts/opentitan/gdbreplay.py
Outdated
| resp = [f'PacketSize={self.MAX_PACKET_LENGTH-16:x}', | ||
| 'ReverseStep+', 'ReverseContinue+'] | ||
| for cap in req.split(';'): | ||
| # supp = cap in ('hwbreak+', 'vContSupported+', 'no-resumed+') |
rivos-eblot
force-pushed
the
dev/ebl/gdb_replay
branch
from
e1a3b55 to
0673593
Compare
rivos-eblot
changed the title
rivos-eblot
force-pushed
the
dev/ebl/gdb_replay
branch
from
0673593 to
82efe7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.