Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single-letter typo and add missing flag in index.md #75

Open
wants to merge 2 commits into
base: ot-earlgrey-8.0.2
Choose a base branch
from

Conversation

pqcfox
Copy link

@pqcfox pqcfox commented Oct 2, 2024

This PR fixes the typo --enable-cococa -> --enable-cocoa in index.md and adds the now-required --enable-pixman flag in the case where --enable-gtk is used.

@pqcfox pqcfox changed the title Fix single-letter typo in index.md Fix typo and add missing flag in index.md Oct 2, 2024
@pqcfox pqcfox changed the title Fix typo and add missing flag in index.md Fix single-letter typo in index.md Oct 2, 2024
@pqcfox pqcfox changed the title Fix single-letter typo in index.md Fix single-letter typo and add missing flag in index.md Oct 2, 2024
Copy link

@rivos-eblot rivos-eblot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rivos-eblot
Copy link

sorry late notice: can you update the commit log messages to include the directory to the change files, as this is the syntax used with QEMU upstream, i.e. [ot] docs/opentitan: fix .....
Thanks

@rivos-eblot rivos-eblot self-requested a review December 5, 2024 18:06
Copy link

@rivos-eblot rivos-eblot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Can you update the commit messages and merge this PR? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants