-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SPI device and PLIC IDs #86
Merged
jwnrt
merged 4 commits into
lowRISC:dev/ot-earlgrey-1.0.0-updates
from
jwnrt:plic-gpios
Dec 13, 2024
Merged
Update SPI device and PLIC IDs #86
jwnrt
merged 4 commits into
lowRISC:dev/ot-earlgrey-1.0.0-updates
from
jwnrt:plic-gpios
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnrt
changed the base branch from
ot-darjeeling-9.1.0
to
dev/ot-earlgrey-1.0.0-updates
December 5, 2024 14:26
rivos-eblot
requested changes
Dec 5, 2024
jwnrt
changed the title
Update PLIC IDs for new interrupts
Update SPI device and PLIC IDs
Dec 9, 2024
rivos-eblot
requested changes
Dec 10, 2024
Coud you add the component the change applies to in the commit message, such as |
…eric mode Updates interrupts and registers to latest versions and removes generic mode entirely.
`TX_EMPTY` has changed to `TX_DONE` which indicates the buffer is empty and there's no ongoing transmission. Added the interrupt to the module but not integrated it yet.
We have broken Darjeeling functionally with changes to Earl Grey. We will have to resolve the errors later, but for now it's not the focus.
rivos-eblot
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SPI device with its new registers and interrupts and removes generic mode (no longer used by EG or DJ).
The PLIC interrupt IDs are also updated for all blocks.