Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SPI device and PLIC IDs #86

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

jwnrt
Copy link

@jwnrt jwnrt commented Dec 5, 2024

This PR updates the SPI device with its new registers and interrupts and removes generic mode (no longer used by EG or DJ).

The PLIC interrupt IDs are also updated for all blocks.

@jwnrt jwnrt changed the base branch from ot-darjeeling-9.1.0 to dev/ot-earlgrey-1.0.0-updates December 5, 2024 14:26
hw/opentitan/ot_hmac.c Outdated Show resolved Hide resolved
@jwnrt jwnrt changed the title Update PLIC IDs for new interrupts Update SPI device and PLIC IDs Dec 9, 2024
@jwnrt jwnrt requested a review from rivos-eblot December 10, 2024 14:16
.github/workflows/build_test.yaml Outdated Show resolved Hide resolved
hw/opentitan/ot_spi_device.c Outdated Show resolved Hide resolved
hw/opentitan/ot_spi_device.c Outdated Show resolved Hide resolved
hw/opentitan/ot_spi_device.c Show resolved Hide resolved
hw/opentitan/ot_uart.c Show resolved Hide resolved
@rivos-eblot
Copy link

Coud you add the component the change applies to in the commit message, such as [ot] hw/opentitan: ot_uart: <msg>. Thanks

…eric mode

Updates interrupts and registers to latest versions and removes generic
mode entirely.
`TX_EMPTY` has changed to `TX_DONE` which indicates the buffer is empty
and there's no ongoing transmission. Added the interrupt to the module
but not integrated it yet.
We have broken Darjeeling functionally with changes to Earl Grey. We
will have to resolve the errors later, but for now it's not the focus.
Copy link

@rivos-eblot rivos-eblot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwnrt jwnrt merged commit 069bc00 into lowRISC:dev/ot-earlgrey-1.0.0-updates Dec 13, 2024
6 checks passed
@jwnrt jwnrt deleted the plic-gpios branch December 13, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants