Skip to content

[Bug]: Custom components cannot be used #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
exqmjmz opened this issue May 23, 2023 · 9 comments
Closed
1 task done

[Bug]: Custom components cannot be used #163

exqmjmz opened this issue May 23, 2023 · 9 comments
Labels
Bug Something isn't working Help wanted Extra attention is needed
Milestone

Comments

@exqmjmz
Copy link

exqmjmz commented May 23, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I place the custom component to the canvas.
The code in the settings is not working.
Only the following is shown:

image

The component found in the code snippet of the custom component will visit the specific address by default.

image image

Components will access:
https://custom-component.lowcoder.dev/index.html

Expected Behavior

Implement the description in the following documentation on the custom component
https://github.com/lowcoder-org/lowcoder/blob/main/docs/build-apps/component-guides/custom-component.md

Steps to reproduce

In the app editor, drag and drop custom components onto the canvas.

Environment

No response

Additional Information

No response

@exqmjmz exqmjmz added Bug Something isn't working Needs triage Needs to be reviewed by core team labels May 23, 2023
@exqmjmz
Copy link
Author

exqmjmz commented May 23, 2023

image

After I changed src to srcDoc, the custom component triggered part of the code

image

But still can't display the custom component content according to the code

image image

@falnyr
Copy link
Contributor

falnyr commented May 24, 2023

Thanks for a detailed bug report, this is a leftover from rebranding.

@falnyr falnyr added good first issue Help wanted Extra attention is needed and removed Needs triage Needs to be reviewed by core team labels May 24, 2023
@falnyr falnyr added this to the Lowcoder V2 milestone May 24, 2023
@thanosits
Copy link

Hello to everyone, I would like to ask you, if anyone knows, the content of https://custom-component.lowcoder.dev/index.html or https://custom-component.openblocks.dev/index.html

Thank you!

@falnyr
Copy link
Contributor

falnyr commented May 28, 2023

Hey @thanosits, the original code lives here: https://custom-component.majiang.co/index.html. This is the Chinese version of Openblocks that all our code is based on. We need to create a build pipeline that will push to a similar location for Lowcoder.

@billyrudi
Copy link

do you have timing for fix it?

@exqmjmz
Copy link
Author

exqmjmz commented Jun 6, 2023

do you have timing for fix it?

NO
#180
Mention needs to be fixed via pipeline or NPM.
But I don't know how to do it.

@konstchri
Copy link

As far as i can see the custom-component index.html needs to be re-implemented. I cannot seem to find the original source code for the extra-hosted content.
Am I missing something?

@falnyr
Copy link
Contributor

falnyr commented Jun 8, 2023

This should now be resolved by #201, can you please check?

@exqmjmz
Copy link
Author

exqmjmz commented Jun 8, 2023

This should now be resolved by #201, can you please check?

normal functioning!
image

@falnyr falnyr closed this as completed Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants