Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix previous incomplete FirebirdSQL PR #1140

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Conversation

mat02
Copy link
Contributor

@mat02 mat02 commented Sep 2, 2024

I've just noticed that after rebase I accidentaly pushed a version with missing 'await' statement ...
This PR fixes that issue, sorry for the hassle.

Copy link

netlify bot commented Sep 2, 2024

👷 Deploy request for lowcoder-test pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0394954

@mat02
Copy link
Contributor Author

mat02 commented Sep 2, 2024

Also, I'm not sure if I should include yarn.lock file in these commits?
Should I run sth like: rm -rf node_nodules && yarn install before that?

@mat02 mat02 changed the title Fix missing await Fix previous incomplete FirebirdSQL PR Sep 3, 2024
@mat02 mat02 marked this pull request as ready for review September 3, 2024 10:56
@ludomikula ludomikula merged commit 722480d into lowcoder-org:dev Sep 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants