Skip to content

Add Env Var for cookie max age: #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Add Env Var for cookie max age: #1221

merged 2 commits into from
Oct 3, 2024

Conversation

dragonpoo
Copy link
Collaborator

@dragonpoo dragonpoo commented Oct 3, 2024

Proposed changes

Add Env Var for cookie max age: LOWCODER_COOKIE_MAX_AGE - with unit "hours"

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Thomasr added 2 commits October 3, 2024 14:35
Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for lowcoder-test canceled.

Name Link
🔨 Latest commit d22d5c5
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/66fee5c4c08c5e000859bc61

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this adaption. Sharp 24h may be a bit too short for some users.

@FalkWolsky FalkWolsky merged commit 1548515 into dev Oct 3, 2024
6 checks passed
@FalkWolsky FalkWolsky deleted the fix/cookie_age_env_var branch October 3, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants