Skip to content

convert snapshot migration to use aggregation pipeline #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2024
Merged

convert snapshot migration to use aggregation pipeline #1324

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24ba4bd
convert snapshot migration to use aggregation pipeline
dragonpoo Nov 20, 2024
0c5c344
delete after copying records
dragonpoo Nov 20, 2024
1eca3af
different migration based on mongo version.
dragonpoo Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 76 additions & 27 deletions ...rvice/lowcoder-server/src/main/java/org/lowcoder/runner/migrations/DatabaseChangelog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
import com.github.cloudyrock.mongock.ChangeSet;
import com.github.cloudyrock.mongock.driver.mongodb.springdata.v4.decorator.impl.MongockTemplate;
import com.github.f4b6a3.uuid.UuidCreator;
import com.mongodb.client.MongoCollection;
import com.mongodb.client.MongoCursor;
import com.mongodb.client.result.DeleteResult;
import lombok.extern.slf4j.Slf4j;
import org.bson.Document;
import org.lowcoder.domain.application.model.Application;
Expand Down Expand Up @@ -44,6 +47,7 @@

import java.time.Instant;
import java.time.temporal.ChronoUnit;
import java.util.Arrays;
import java.util.List;
import java.util.Set;

Expand Down Expand Up @@ -313,41 +317,86 @@ private int getMongoDBVersion(MongockTemplate mongoTemplate) {
@ChangeSet(order = "026", id = "add-time-series-snapshot-history", author = "")
public void addTimeSeriesSnapshotHistory(MongockTemplate mongoTemplate, CommonConfig commonConfig) {
int mongoVersion = getMongoDBVersion(mongoTemplate);
if (mongoVersion < 5) {
log.warn("MongoDB version is below 5. Time-series collections are not supported. Upgrade the MongoDB version.");
}

// Create the time-series collection if it doesn't exist
if (!mongoTemplate.collectionExists(ApplicationHistorySnapshotTS.class)) {
if(mongoVersion < 5) {
mongoTemplate.createCollection(ApplicationHistorySnapshotTS.class);
} else {
mongoTemplate.createCollection(ApplicationHistorySnapshotTS.class, CollectionOptions.empty().timeSeries("createdAt"));
Instant thresholdDate = Instant.now().minus(commonConfig.getQuery().getAppSnapshotKeepDuration(), ChronoUnit.DAYS);

if (mongoVersion >= 5) {
// MongoDB version >= 5: Use manual insert query
if (!mongoTemplate.collectionExists(ApplicationHistorySnapshotTS.class)) {
mongoTemplate.createCollection(ApplicationHistorySnapshotTS.class,
CollectionOptions.empty().timeSeries("createdAt"));
}

// Aggregation pipeline to fetch the records
List<Document> aggregationPipeline = Arrays.asList(
new Document("$match", new Document("createdAt", new Document("$gte", thresholdDate))),
new Document("$project", new Document()
.append("applicationId", 1)
.append("dsl", 1)
.append("context", 1)
.append("createdAt", 1)
.append("createdBy", 1)
.append("modifiedBy", 1)
.append("updatedAt", 1)
.append("id", "$_id")) // Map `_id` to `id` if needed
);

MongoCollection<Document> sourceCollection = mongoTemplate.getDb().getCollection("applicationHistorySnapshot");
MongoCollection<Document> targetCollection = mongoTemplate.getDb().getCollection("applicationHistorySnapshotTS");

// Fetch results and insert them into the time-series collection
try (MongoCursor<Document> cursor = sourceCollection.aggregate(aggregationPipeline).iterator()) {
while (cursor.hasNext()) {
Document document = cursor.next();
targetCollection.insertOne(document); // Insert into the time-series collection
}
}

// Delete the migrated records
Query deleteQuery = new Query(Criteria.where("createdAt").gte(thresholdDate));
DeleteResult deleteResult = mongoTemplate.remove(deleteQuery, ApplicationHistorySnapshot.class);

log.info("Deleted {} records from the source collection.", deleteResult.getDeletedCount());
} else {
// MongoDB version < 5: Use aggregation with $out
if (!mongoTemplate.collectionExists(ApplicationHistorySnapshotTS.class)) {
mongoTemplate.createCollection(ApplicationHistorySnapshotTS.class); // Create a regular collection
}

// Aggregation pipeline with $out
List<Document> aggregationPipeline = Arrays.asList(
new Document("$match", new Document("createdAt", new Document("$gte", thresholdDate))),
new Document("$project", new Document()
.append("applicationId", 1)
.append("dsl", 1)
.append("context", 1)
.append("createdAt", 1)
.append("createdBy", 1)
.append("modifiedBy", 1)
.append("updatedAt", 1)
.append("id", "$_id")), // Map `_id` to `id` if needed
new Document("$out", "applicationHistorySnapshotTS") // Write directly to the target collection
);

mongoTemplate.getDb()
.getCollection("applicationHistorySnapshot")
.aggregate(aggregationPipeline)
.toCollection();

// Delete the migrated records
Query deleteQuery = new Query(Criteria.where("createdAt").gte(thresholdDate));
DeleteResult deleteResult = mongoTemplate.remove(deleteQuery, ApplicationHistorySnapshot.class);

log.info("Deleted {} records from the source collection.", deleteResult.getDeletedCount());
}
Instant thresholdDate = Instant.now().minus(commonConfig.getQuery().getAppSnapshotKeepDuration(), ChronoUnit.DAYS);
List<ApplicationHistorySnapshot> snapshots = mongoTemplate.find(new Query().addCriteria(Criteria.where("createdAt").gte(thresholdDate)), ApplicationHistorySnapshot.class);
snapshots.forEach(snapshot -> {
ApplicationHistorySnapshotTS applicationHistorySnapshotTS = new ApplicationHistorySnapshotTS();
applicationHistorySnapshotTS.setApplicationId(snapshot.getApplicationId());
applicationHistorySnapshotTS.setDsl(snapshot.getDsl());
applicationHistorySnapshotTS.setContext(snapshot.getContext());
applicationHistorySnapshotTS.setCreatedAt(snapshot.getCreatedAt());
applicationHistorySnapshotTS.setCreatedBy(snapshot.getCreatedBy());
applicationHistorySnapshotTS.setModifiedBy(snapshot.getModifiedBy());
applicationHistorySnapshotTS.setUpdatedAt(snapshot.getUpdatedAt());
applicationHistorySnapshotTS.setId(snapshot.getId());
mongoTemplate.insert(applicationHistorySnapshotTS);
mongoTemplate.remove(snapshot);
});

// Ensure indexes if needed
// Ensure indexes on the new collection
ensureIndexes(mongoTemplate, ApplicationHistorySnapshotTS.class,
makeIndex("applicationId"),
makeIndex("createdAt")
);
makeIndex("createdAt"));
}


private void addGidField(MongockTemplate mongoTemplate, String collectionName) {
// Create a query to match all documents
Query query = new Query();
Expand Down
Loading