Skip to content

Fix table row selection for applications created in older versions of Lowcoder #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Fix table row selection for applications created in older versions of Lowcoder #1346

merged 4 commits into from
Nov 27, 2024

Conversation

nangelov-eti
Copy link

Proposed changes

We found that adding a simple check resolved the issue. When a table row contains null values, we were unable to select the row or interact with the button in that row. The root cause was that when value is null or undefined, calling Object.keys(value) tries to convert it to an object, resulting in the error: TypeError: Cannot convert undefined or null to object at Function.keys. To address this, we added a check to ensure value is neither null nor undefined before attempting to access its keys.

Please review the changes for any potential side effects, though I haven't observed any. This should enhance backwards compatibility.

This PR fixes #1332

Screenshot 2024-11-27 111509
Screenshot 2024-11-27 111656

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Copy link

netlify bot commented Nov 27, 2024

👷 Deploy request for lowcoder-test pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e2a9ad0

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! You found it. This is truly amazing and we feel very thankful that you offered this solution!

@FalkWolsky FalkWolsky merged commit 6bf8b1c into lowcoder-org:dev Nov 27, 2024
3 checks passed
@nangelov-eti nangelov-eti deleted the fix/table-row-selection branch November 27, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants