Skip to content

Conventional commit #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2023
Merged

Conventional commit #151

merged 4 commits into from
May 23, 2023

Conversation

falnyr
Copy link
Contributor

@falnyr falnyr commented May 16, 2023

Proposed changes

To make releases and CHANGELOG easier, conventional commit and automatic release can be added to the pipeline. This will take care of semantic versioning, CHANGELOG, GitHub releases etc.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

@falnyr falnyr added the Deployment Pipelines Changes related to CI/CD label May 16, 2023
@falnyr falnyr added this to the Lowcoder V2 milestone May 16, 2023
@falnyr falnyr requested a review from ludomikula May 16, 2023 11:20
@falnyr falnyr self-assigned this May 16, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@falnyr falnyr force-pushed the feat/conventional-commit branch from 7f03d14 to cef3147 Compare May 23, 2023 09:58
@falnyr falnyr changed the title WIP: conventional commit Conventional commit May 23, 2023
Automated releases may happen in the future, at the moment we just need to have commit structure.
@falnyr falnyr merged commit 49943ee into main May 23, 2023
@falnyr falnyr deleted the feat/conventional-commit branch May 23, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deployment Pipelines Changes related to CI/CD
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant