Skip to content

Feat/usability updates #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2023
Merged

Feat/usability updates #211

merged 4 commits into from
Jun 18, 2023

Conversation

ludomikula
Copy link
Collaborator

@ludomikula ludomikula commented Jun 17, 2023

Proposed changes

  • make default biz thresholds configurable via application.yaml and environment properties
  • add possibility to disable certain endpoints via configuration (eg. overriding biz thresholds using API)
  • add OpenAPI specification and a web UI to browse it

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

n/a

@ludomikula ludomikula requested review from falnyr and FalkWolsky June 18, 2023 09:06
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the 2 points about ENV VAR Names as we briefly discussed.

@ludomikula ludomikula force-pushed the feat/usability_updates branch 2 times, most recently from 7b73fc5 to ee7dca9 Compare June 18, 2023 11:19
@ludomikula ludomikula force-pushed the feat/usability_updates branch from ee7dca9 to c640eb6 Compare June 18, 2023 11:22
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the cleanup!

@ludomikula ludomikula merged commit be22a1c into main Jun 18, 2023
@ludomikula ludomikula deleted the feat/usability_updates branch June 18, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants