Skip to content

Allow usage of SSL certificate in frontend #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

ludomikula
Copy link
Collaborator

Proposed changes

This change reintroduces the possibility to use SSL certificates to start lowcoder with HTTPS.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

n/a

FalkWolsky
FalkWolsky previously approved these changes Jun 21, 2023
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these changes and additions!

@ludomikula ludomikula force-pushed the fix/add_nginx_https branch from 5b88a45 to 3ab75eb Compare June 21, 2023 11:38
@ludomikula ludomikula requested a review from FalkWolsky June 21, 2023 14:00
@ludomikula ludomikula self-assigned this Jun 21, 2023
@ludomikula ludomikula merged commit d457bb1 into main Jun 21, 2023
@ludomikula ludomikula deleted the fix/add_nginx_https branch June 21, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants