Skip to content

removed the test object from modules view mode #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 5, 2023

Conversation

joenan
Copy link
Contributor

@joenan joenan commented Jul 5, 2023

removed the test object from modules view mode

"test": {
	"compType": "string",
	"comp": "255"
}

The test object was removed from both the inputs and output arrayss
data.applicationDSL.ui.comp.io.inputs[]
data.applicationDSL.ui.comp.io.outputs[]

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put application-lowcoder.yml to gitignore.
Rest is super.

FalkWolsky
FalkWolsky previously approved these changes Jul 5, 2023
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good now. Thank you

@joenan joenan changed the title changed app data for view to remove test object in app data for produ… removed the test object from modules view mode Jul 5, 2023
… adds removes test object from the outputs and inputs array of a module view.
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope, this time the commit comment passes the test

@FalkWolsky FalkWolsky merged commit f4e8bd9 into lowcoder-org:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants