Skip to content

feat: grid column settings in theme #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2023

Conversation

aaron1604
Copy link
Contributor

Proposed changes

Added Grid columns settings in Theme settings. Now instead of the default 24 grid columns, you can customize it through theme settings.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • [ x ] Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Grid column settings are there in theme settings.

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for classy-bombolone-94aec0 ready!

Name Link
🔨 Latest commit 8ab1298
🔍 Latest deploy log https://app.netlify.com/sites/classy-bombolone-94aec0/deploys/64aa9ebf3ef16d00082d39c9
😎 Deploy Preview https://deploy-preview-270--classy-bombolone-94aec0.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A wonderful contribution. Thank you very much!

@FalkWolsky FalkWolsky merged commit 1a28ed3 into lowcoder-org:main Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants