Skip to content

Remove default log file appenders #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Conversation

ludomikula
Copy link
Collaborator

Proposed changes

Since lowcoder is mostly run in containers, logging to files by default is not a good behavior.
This change removes file logger appenders and keeps only console logging.
In all-in-one image logging is still kept in a log file due to the configuration of the service executed within the container.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

n/a

@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for classy-bombolone-94aec0 canceled.

Name Link
🔨 Latest commit 2eaacd9
🔍 Latest deploy log https://app.netlify.com/sites/classy-bombolone-94aec0/deploys/64b5aade1181830008d002a0

@ludomikula ludomikula requested a review from FalkWolsky July 17, 2023 20:56
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!!

@FalkWolsky FalkWolsky merged commit e4d9f22 into main Jul 17, 2023
@FalkWolsky FalkWolsky deleted the remove_log_file_appenders branch July 17, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants