Skip to content

Fix_Optimize_JSON_Lottie_Component #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

mousheng
Copy link
Contributor

  1. move svg to folder lowcoder-design
  2. All options support multiple languages
  3. add attribute keepLastFrame,Prevent components from becoming blank
  4. 5.change backgroundcolor follow the canvas color
  5. delete MARGIN and PADDING style

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

1.move svg to folder lowcoder-design
2.All options support multiple languages
3.add attribute keepLastFrame,Prevent components from becoming blank
4.change backgroundcolor follow the canvas color
5.delete MARGIN and PADDING style
@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for lowcoder-cloud ready!

Name Link
🔨 Latest commit a967f24
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-cloud/deploys/64b90d4a99d5ac000878bbf5
😎 Deploy Preview https://deploy-preview-294--lowcoder-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 18, 2023

👷 Deploy request for classy-bombolone-94aec0 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a967f24

@FalkWolsky
Copy link
Contributor

That is a valuable contribution. Thank you very much!
We need to check about margin / padding, as we introduced it by the current changes.
@aaron1604 will please have a look and decide.

@mousheng
Copy link
Contributor Author

image
In fact, in the current version, the padding/margin setting is invalid, and during my testing, the component looks very unattractive after setting padding/margin because if you want to adjust the animation size, you can directly adjust the component size

@FalkWolsky FalkWolsky self-requested a review July 20, 2023 11:14
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your valuable contribution! The "stop at last frame" is truly a good addition. We also will take care of fixing the margin/padding as you advise.

@FalkWolsky FalkWolsky merged commit 7678ce0 into lowcoder-org:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants