Skip to content

Added data field to add external token server #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Conversation

FalkWolsky
Copy link
Contributor

Proposed changes

Agora Meetings need a secured encrypted Token for meeting-rooms. To get this token a small so-called "Token Server" is used, which handles backend communication (for security reasons). The new commit makes this configurable.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for lowcoder-cloud ready!

Name Link
🔨 Latest commit 5a05656
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-cloud/deploys/65566db60e401700080a7152
😎 Deploy Preview https://deploy-preview-505--lowcoder-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@FalkWolsky FalkWolsky changed the base branch from main to dev November 16, 2023 19:31
@FalkWolsky FalkWolsky merged commit 3788c5e into dev Nov 16, 2023
@FalkWolsky FalkWolsky deleted the agora-integrationn branch November 16, 2023 19:36
@FalkWolsky FalkWolsky restored the agora-integrationn branch November 18, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants