Fix two small bugs with the RestAPI Datasource #798
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
First bug:
Spring automatically transforms binary content to base64, therefore the
logic in the RestApiExecutor was causing the data to be encoded twice,
causing much confusion and frustration for several weeks actually.
Second bug:
the fileUtils#saveDataAsFile function was not actually setting the type
correctly when attempting to convert the base64 data to a binary blob,
thus the files would always download as a 'dms' file and it would
never actually be openable. This also caused a lot of confusion. Both of
these bugs together made it impossible to tell why stuff was broken.
Combined this means that anytime you were trying to download binary data
you would never actually be able to open the file, as it would be only
base64 data inside of it.
Types of changes
Checklist
Further comments
I tested by creating a repo with a test release and an xlsx file in it. https://github.com/snowe2010/test-release-downloads/releases/tag/v1
I then wrote a small app with two queries, one to retrieve asset from github, the other to download the asset to my computer.


I tested both with and without my change to each file. Both are necessary to get the file download working.