Skip to content

Upgrade dependencies, refactor services, fix data de/serialization #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 18, 2024

Conversation

ludomikula
Copy link
Collaborator

API service changes

  • update all libraries to current versions and refactor code where necessary
  • refactor build to produce jar with dependencies instead of fat jar, update docker image build to accommodate the change
  • replace all javax. dependencies with jakarta. counterparts
  • remove automatic cyclic dependencies breaking and fix cyclic dependencies
  • refactor all services to use proper proxying via interfaces

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for lowcoder-test canceled.

Name Link
🔨 Latest commit a231f90
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/6620ea40e86048000860c9ab

@ludomikula ludomikula changed the title Update javax to jakarta Upgrade dependencies, refactor services, fix data de/serialization Apr 18, 2024
@ludomikula ludomikula merged commit 8e0ac77 into dev Apr 18, 2024
6 checks passed
@ludomikula ludomikula deleted the update_javax_to_jakarta branch April 18, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant