Add new Tour component #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently only shows a tour modal, not connected to any components can be triggered with the Control a Component event handler
still doesn't work, but I think I'm closer. Currently the step refs are always undefined.
I don't know exactly what I was doing wrong, so I copied the dropdown control and modified it to accept the editor state. this could most likely be done cleaner by allowing for the existing dropdown control to accept a function with generic arguments, but that can be cleaned up later.
turns out it just required ?!
Also update the i18n files.
update title and description to allow any html
also fixes issues with step properties always being set, thus making root properties do nothing.
also disable indicators for now
👷 Deploy request for lowcoder-test pending review.Visit the deploys page to approve it
|
FalkWolsky
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds a new Tour component to the list of components, allowing creators to provide a product tour for their apps.
Types of changes
What types of changes does your code introduce to Lowcoder?
Put an
xin the boxes that apply.Checklist
Further comments
This PR adds a new Antd Tour Component to the list of components available in Lowcoder. It adds a majority of the properties and configuration settings that are available in the Antd version, but not all of them.
Here are several example apps showing the component working as intended, in a majority of the cases.
show tour settings.json
show step settings.json
test all against tour.json
Some cases do not work:
Here are some videos showing the feature:
Screen.Recording.2024-04-19.at.5.48.06.PM.mov
Screen.Recording.2024-04-19.at.5.49.59.PM.mov