Skip to content

Translation small bugfixes #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2024
Merged

Translation small bugfixes #831

merged 3 commits into from
Apr 28, 2024

Conversation

FalkWolsky
Copy link
Contributor

Proposed changes

In translation files it is possible to work with variables like {productName). When one translated the translation files by a machine, sometimes it can happen, that also these variable names get translated - which would lead into an App crash.
We soften down this behaviour and only post it in the log now. Also, we print out then the name of the missing variable.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link

netlify bot commented Apr 28, 2024

Deploy Preview for lowcoder-test ready!

Name Link
🔨 Latest commit 97a54fb
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/662e2b6f5c846c000861a9e5
😎 Deploy Preview https://deploy-preview-831--lowcoder-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@FalkWolsky FalkWolsky merged commit d7bc60c into dev Apr 28, 2024
3 checks passed
@FalkWolsky FalkWolsky deleted the translation branch April 28, 2024 10:57
Copy link

netlify bot commented Apr 28, 2024

Deploy Preview for lowcoder-test ready!

Name Link
🔨 Latest commit 0804e69
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/662e2b785858550008281ab6
😎 Deploy Preview https://deploy-preview-831--lowcoder-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant