-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add h-event microformat markup #93
✨ add h-event microformat markup #93
Conversation
This looks great; my only concern is that the element |
That makes sense. In previous use I've done To clarify, which Expression will give me a parseable timestamp? I confess to not being super experienced with Handlebars. |
That's alright, first time for everything! It looks like we already generate a machine-readable timestamp on the server here and pass it through to Handlebars here. We don't seem to use it in the actual Handlebars file! The only thing is that that gives us the times in UTC, which is probably less helpful that providing them in their local timezone. So I'd change those lines to |
In the
|
a9864bd
to
28cf1a3
Compare
Added two invisible <time> tags which allow for microformat parsing of dt-start & dt-end
I added two invisible I didn't adjust the https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toISOString I dug through the spec, and couldn't find any specific guidelines for this situation. I don't think this is an issue, since any microformats reader parsing an h-event should compensate for the reading users TZ anyways. For reference: https://indieweb.org/datetime I checked the final rendered page against this parser, again: https://go.microformats.io/ This covers all the basic properties of an |
Very happy to merge this, thank you! |
As referenced in #90
Added the invisible class names that make up the microformat requirements for an "h-event"
http://microformats.org/wiki/h-event
Including:
I tested it using the Go Microformats Parser: https://go.microformats.io
And it parses and renders correctly!