-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: i18n support #94
Conversation
This is a superb feat, thank you so much so far! I'm hoping to have time to review this early this month. |
When I create a new event, there is an error: |
There's currently an issue with this implementation where nested Handlebars expressions don't get rendered, so this i18n string:
Comes out as:
I think the easiest way to get around this is to separate the internal Handlebars expressions from the translation strings, since it seems quite complex to render nested Handlebars expressions. |
The issue here is that the event creation code expects the start and end date to be supplied in a very specific format, and that format only comes across as expected when the datepicker is set to the |
resolve #13
Initial implementation of i18n, the future will add the part of the user's independent choice of language.
I'm relatively new to js, so please point out any errors, thanks!