Add new Discussions plugin #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nixinova
reviewed
Jul 30, 2021
Co-authored-by: Nixinova <nixinova@gmail.com>
| do { | ||
| console.debug(`metrics/compute/${login}/discussions > retrieving discussions after ${cursor}`) | ||
| const {user:{repositoryDiscussions:{edges = [], nodes = []} = {}}} = await graphql(queries.discussions.categories({login, after:cursor ? `after: "${cursor}"` : ""})) | ||
| cursor = edges?.[edges?.length - 1]?.cursor |
There was a problem hiding this comment.
Super minor nitpick, but I think
edges?.[edges?.length - 1]has a slightly redundant check. If edges == null, the expression inside the brackets shouldn't be evaluated.
For example
const foo = void 0;
foo?.[foo.bar] // undefined, doesn't throw errorThere was a problem hiding this comment.
Yes I think you're right 🙂
Eventually I'd like to move to Array.at with edges.at(-1)?.cursor which seems cleaner, but I'm not sure that both node used version and vercel's one currently support it
There was a problem hiding this comment.
Array#at was added to Node literally yesterday.
|
Can discussions be moved to be under followup? Thats a more natural position than at the end. |
|
Yes it would makes more sense. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new discussion plugin to display how many discussion user has started, and how many comments and answers provided.
Also track most posted categories