Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/isocalendar): algorithm improvements for date ranges #759

Merged
merged 1 commit into from
Jan 9, 2022

Conversation

lowlighter
Copy link
Owner

@lowlighter lowlighter commented Jan 9, 2022

Closes #753
Relates to #598

  • This removes the "padding" trick to just force the starting date on a sunday (day 0 in JS)
  • It also forces the time to be set at 00:00:00.000 for starting ranges and 23:59:59.999 for ending ranges, rather than keeping the current time, which could causes some days to be misreported
  • Calendar are now fetched 4 weeks (28 days) at a time to avoid API timeouts for large users
  • Merged the fetching between isocalendar and other statistics to avoid duplicate calls

  • todo: retest in a few day to ensure sunday logic is working

@lowlighter lowlighter merged commit 469a5ec into master Jan 9, 2022
@lowlighter lowlighter deleted the fix-isocalendar-improvements branch January 9, 2022 18:54
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restricts average commits per day by fetched data
1 participant