Skip to content

Commit

Permalink
Merge pull request #244 from lowlydba/suggestion-fixes
Browse files Browse the repository at this point in the history
Suggestion fixes
  • Loading branch information
lowlydba authored Aug 19, 2022
2 parents 731995c + 6bf4535 commit 443f808
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
5 changes: 3 additions & 2 deletions install_dba-multitool.sql
Original file line number Diff line number Diff line change
Expand Up @@ -3749,7 +3749,7 @@ sp_sizeoptimiser - Recommends space saving measures for data footprints.
Part of the DBA MultiTool http://dba-multitool.org
Version: 20220124
Version: 20220818
MIT License
Expand Down Expand Up @@ -4020,6 +4020,7 @@ BEGIN
AND ([c].[name] LIKE ''%date%'' OR [c].[name] LIKE ''%time%'')
AND [c].[name] NOT LIKE ''%UpdatedBy%''
AND [c].[name] NOT LIKE ''%days%''
AND ([c].[name] <> ''timestamp'' AND [ty].[name] NOT IN (''timestamp'', ''rowversion''))
AND [ty].[name] NOT IN (''datetime'', ''datetime2'', ''datetimeoffset'', ''date'', ''smalldatetime'', ''time'');'
FROM #Databases;
EXEC sp_executesql @CheckSQL, N'@CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @CheckNumber = @CheckNumber, @BaseURL = @BaseURL;
Expand Down Expand Up @@ -4050,7 +4051,7 @@ BEGIN
UNION
SELECT QUOTENAME(SCHEMA_NAME(t.schema_id)) + ''.'' + QUOTENAME(t.name)
,QUOTENAME(c.name)
,N''Possible arbitrary variable length column in use. Is the '' + ty.name + N'' length of '' + CAST (c.max_length AS varchar(MAX)) + N'' based on requirements''
,N''Possible arbitrary variable length column in use. Is the '' + ty.name + N'' length of '' + CAST (c.max_length AS varchar(MAX)) + N'' based on requirements?''
,CONCAT(@BaseURL COLLATE database_default, ''arbitrary-varchar-length'')
FROM sys.columns as c
INNER JOIN sys.tables as t on t.object_id = c.object_id
Expand Down
5 changes: 3 additions & 2 deletions sp_sizeoptimiser.sql
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ sp_sizeoptimiser - Recommends space saving measures for data footprints.
Part of the DBA MultiTool http://dba-multitool.org
Version: 20220124
Version: 20220818
MIT License
Expand Down Expand Up @@ -395,6 +395,7 @@ BEGIN
AND ([c].[name] LIKE ''%date%'' OR [c].[name] LIKE ''%time%'')
AND [c].[name] NOT LIKE ''%UpdatedBy%''
AND [c].[name] NOT LIKE ''%days%''
AND ([c].[name] <> ''timestamp'' AND [ty].[name] NOT IN (''timestamp'', ''rowversion''))
AND [ty].[name] NOT IN (''datetime'', ''datetime2'', ''datetimeoffset'', ''date'', ''smalldatetime'', ''time'');'
FROM #Databases;
EXEC sp_executesql @CheckSQL, N'@CheckNumber TINYINT, @BaseURL VARCHAR(1000)', @CheckNumber = @CheckNumber, @BaseURL = @BaseURL;
Expand Down Expand Up @@ -425,7 +426,7 @@ BEGIN
UNION
SELECT QUOTENAME(SCHEMA_NAME(t.schema_id)) + ''.'' + QUOTENAME(t.name)
,QUOTENAME(c.name)
,N''Possible arbitrary variable length column in use. Is the '' + ty.name + N'' length of '' + CAST (c.max_length AS varchar(MAX)) + N'' based on requirements''
,N''Possible arbitrary variable length column in use. Is the '' + ty.name + N'' length of '' + CAST (c.max_length AS varchar(MAX)) + N'' based on requirements?''
,CONCAT(@BaseURL COLLATE database_default, ''arbitrary-varchar-length'')
FROM sys.columns as c
INNER JOIN sys.tables as t on t.object_id = c.object_id
Expand Down

0 comments on commit 443f808

Please sign in to comment.