fix: prefer forwarded SSH agent over 1Password agent #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
lox
force-pushed
the
ssh-agent-forwarding-fix
branch
from
49c56cf to
d2af439
Compare
Owner
Author
|
@codex review? |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. |
Use SSH Match directive to conditionally apply IdentityAgent only when SSH_AUTH_SOCK is not set. This enables agent forwarding while maintaining 1Password as fallback for local sessions and GUI apps. The Match exec tests if SSH_AUTH_SOCK is empty: - Empty → Use 1Password IdentityAgent - Set → Skip IdentityAgent, use existing agent (forwarded or local) Fixes SSH agent forwarding with `ssh -A` while preserving 1Password agent for local sessions, GUI apps, and non-forwarded SSH connections. Requires OpenSSH 6.5+ (both machines have 9.8+)
lox
force-pushed
the
ssh-agent-forwarding-fix
branch
from
79a2f55 to
afa7534
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use SSH
Match execto conditionally applyIdentityAgentonly whenSSH_AUTH_SOCKis not set. This enables agent forwarding while maintaining 1Password as fallback.Problem
IdentityAgentin ssh/config always overrides forwarded SSH agents. When usingssh -A port-charlotte, the remote machine would try to use its local 1Password agent instead of the forwarded agent, causing authentication failures:Solution
The
Match exectests ifSSH_AUTH_SOCKis empty:Behavior
ssh -A(forwarded)ssh(no forwarding)Requires OpenSSH 6.5+ (both machines have 9.8+)