You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The number of traits for fixed and movable functions. Once Handle generated code consistenly #48 has been implemented, I believe we can reduce this to one trait for fixed and one trait for movable functions.
The relationship of AdcChannel/InputFunction/OutputFunction to the traits for fixed and movable functions. There are so many traits, and a lot of complexity when using them in function signatures. I don't have a clear vision here, yet, only the vague feeling that there must be a better way.
The public API for the SWM lives in the gpio module, which is weird at best, confusing at worst. Once Handle generated code consistenly #48 is implemented, it can be moved to the new FixedFunction/MovableFunction types.
The gpio and swm modules are entangled with each other. I think it would be less complex, if swm owned Pin and related types, and gpio was restricted to GPIO APIs.
The text was updated successfully, but these errors were encountered:
Updated original comment. Thanks to #90 and #91, the API has been radically simplified. There are only 2 methods total now (down from 8): One for assigning functions, one for unassigning them.
Updated original comment. #92 moved the function assignment API to the swm module. I also added another item about the entanglement between the gpio and swm modules.
I'm unhappy with some aspects of the
swm
module's design:AdcChannel
/InputFunction
/OutputFunction
to the traits for fixed and movable functions. There are so many traits, and a lot of complexity when using them in function signatures. I don't have a clear vision here, yet, only the vague feeling that there must be a better way.gpio
module, which is weird at best, confusing at worst. Once Handle generated code consistenly #48 is implemented, it can be moved to the newFixedFunction
/MovableFunction
types.gpio
andswm
modules are entangled with each other. I think it would be less complex, ifswm
ownedPin
and related types, andgpio
was restricted to GPIO APIs.The text was updated successfully, but these errors were encountered: