Move pin-related code to SWM API #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move pin-related code to the SWM API. The GPIO-related bits have been left in the
gpiomodule. I like this better, as the SWM API owning the pins is more logical than the GPIO API owning them. GPIO is only one use of the pins, after all.I'm still not totally happy with the API, as the SWM and GPIO modules are still a bit intertwined. I think this is good enough for now, however. I'll revisit the issue after I had a chance to think about it for a while.
I also snuck in a small update to the build infrastructure in here. It seemed small enough that I didn't want to put it in its own pull request.
Close #76.