Merge all crates into one #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that the previous approach to portability hasn't worked out well. Having three crates was more complicated, led to duplicated code, and it wasn't even successful: The common crate still contained conditional code, depending on which target was compiled. This commit collapses the three crates into a single one that uses conditional compilation all the way. This is just a first step, but I believe it's already better than what we had before.
|
I'm merging this now. As I said in the other PR, I need a new release out today. @david-sawatzke I hope it's okay that I'm merging/releasing without a review. I'm happy to discuss and make change later, as required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that the previous approach to portability hasn't worked out
well. Having three crates was more complicated, led to duplicated code,
and it wasn't even successful: The common crate still contained
conditional code, depending on which target was compiled.
This commit collapses the three crates into a single one that uses
conditional compilation all the way. This is just a first step, but I
believe it's already better than what we had before.