Spi impl #204
Merged
Spi impl #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-sawatzke
force-pushed
the
spi
branch
2 times, most recently
from
5f3949a
to
b6c99ed
Compare
hannobraun
reviewed
Jan 30, 2020
|
Ok, fixed the review issues and some other things (pins overlap with i2c, bitlength was at 1) as well as testing it, ready to go now |
hannobraun
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
Looking good! I didn't test myself (limited time at the moment), but if you've tested, that's good enough right now. One of my clients is interested in this, so I might be getting into it sooner or later anyway.
Thank you, @david-sawatzke!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.