Remove core peripherals from Peripherals
#209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm currently working on an example that shows how to use it with this HAL.
Re-export `pac::CorePeripherals` as a convenient alternative. The core peripherals don't really need to be part of `Peripherals`. We're not actually doing anything with them; it's just slightly more convenient for the user. Although not much convenience is lost, as the pretty minimal changes to the examples show. The reason I'm removing them is to improve interoperability with RTFM, as that assumes control over the core peripherals. As of before this commit, using this HAL with RTFM would give the user safe access to two sets of core peripherals, which seems like asking for trouble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of this is to improve interoperability with RTFM. Interoperability is still not very good (due to the lifetimes requires all over the API), but it's a start.