Move pin API to dedicated module #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pins don't can't really be assigned to a single peripheral, like many other concepts in this HAL. GPIO, SWM, and IOCON all do things related to them. Some time ago, I decided to move them to the `swm` module, for lack of a better idea. I believe this wasn't a good decision. They belong in their own module. In my opinion, this is the least confusing. There might be more things we can do to improve things, but I think this is already a good first step.
This means the name `Peripherals` no longer fully fits, but it's definitely a better place for it than within the SWM peripheral.
david-sawatzke
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't leave the API in a perfect state, but it's a clear improvement. I'm planning some more improvements to improve RTFM compatibility, and maybe I'll move more stuff around while I'm doing that.