Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up pins module #224

Merged
merged 7 commits into from
Mar 20, 2020
Merged

Clean up pins module #224

merged 7 commits into from
Mar 20, 2020

Conversation

hannobraun
Copy link
Member

No description provided.

@hannobraun
Split pins into multiple modules
38e51a5 
Other modules have gotten the same treatment, and even though they were
much bigger and messier than `pins`, I'm about to add more stuff to
`pins` and figured, why not be proactive and do this _before_ it becomes
a huge mess.
@hannobraun
Rename pins::state::PinState to pins::State
cbc8bd0
@hannobraun
Rename pins::PinTrait to pins::Trait
bdc3ebe
david-sawatzke
david-sawatzke approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@david-sawatzke david-sawatzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there may be some broken links, but seems good to me

src/pins/state.rs Show resolved Hide resolved
src/pins/state.rs Show resolved Hide resolved
@hannobraun
Copy link
Member Author

I fixed all broken links in the pins documentation and updated some of it. Merging, since the previous commits were already approved, and the new commits only change documentation, which is largely outdated and in need of an update anyways.

@hannobraun hannobraun merged commit db8e2f5 into lpc-rs:master Mar 20, 2020
@hannobraun hannobraun deleted the pins branch March 20, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-sawatzke david-sawatzke david-sawatzke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannobraun @david-sawatzke