Add support for enabling/disabling SPI interrupts #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased, no changes. |
david-sawatzke
approved these changes
Jul 21, 2020
src/spi/interrupts.rs
Outdated
|
|
||
| impl Interrupts { | ||
| pub(super) fn enable<I: Instance>(&self, spi: &I) { | ||
| spi.intenset.modify(|_, w| { |
There was a problem hiding this comment.
If I'm reading the documentation correctly, intenset won't clear the interrupt-enable bits, so a write is the more correct thing to do here, although modify looks like it'll work fine
There was a problem hiding this comment.
I think you're right. The documentation isn't super-explicit in this regard, but it makes more sense and would be in line with how these types of registers usually work.
I'll make the change (and do some experimentation to verify) before merging.
No problem. Thanks for the review! |
|
Made the suggested change. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.