Seal instance traits #257
Merged
Seal instance traits #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm sure there are many other traits that need to be sealed, but we got to start somewhere.
I think the previous text was wrong for multiple reasons: 1. They are sealed now, so we no longer need to explicitly state that they shouldn't be implemented. 2. The "or used" bit was probably always wrong. You always needed them as trait bounds to make code generic over peripheral instances. 3. Given that they need to be used anyway, what should and what shouldn't be considered a breaking change becomes a difficult distinction. Let's just make it simple and consider all breaking changes to actually be breaking changes.
david-sawatzke
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.