Add support for DMA-based reading from USART #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This makes the transfer code more generic and prepares it for the addition of peripheral-to-memory transfers.
Only buffers can provide a transfer count, but the trait should also be implementable by peripherals.
This is required to support buffers as transfer destinations.
We expose it in type signatures, which means our users may need to depend on it. I believe it is best practive to re-export it in this case, as that relieves the user from having to manage their own dependency on it (while keeping the version in sync at all times).
This is required to support buffers as destinations.
It hasn't served a purpose since I made `Channel::start_transfer` private.
|
Rebased, ready for review. @david-sawatzke: To address your comment on #260, I've pushed a commit that panics, if the buffer is too long. Is that what you had in mind? I don't think a |
david-sawatzke
approved these changes
Jul 26, 2020
david-sawatzke
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #260. I recommend reviewing/merging that one first.
Close #124.