Add new TV icon in iOS 14 #684
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated readme
Updated temperature from file to return zero on error instead of returning.
Instead of returning zero immediately on an error reading temperature from file, retry once in case of conflict on initial read
Error fix
Updated project name
Fixed NaN error
Retry failing - reverting to set to 0
Imported airconPro from https://github.com/Cloudore/homebridge-broadlink-rm
* Fixed unused mode hexcodes The heat/cool/auto hex codes in the configuration were unused ?!?!? This is to use these to set the mode, and the temp hex to set temperature for units that have seperate codes. mode hex codes are optional in the config. Temperature codes will be sent instead assuming these contain the mode information for the AC unit. * Mode change clean-up Separated mode change code from sendTemperature to setTargetHeatingCoolingState to allow it to run when only the mode changes.
* Turn the unit on first if required, and defined
iOS13/tvOS13 appears to poll the device status more frequently. Adjusted default temperature update times to reduce duplication
* Updated README.md to include notes on new features
* Fixed unused mode hexcodes The heat/cool/auto hex codes in the configuration were unused ?!?!? This is to use these to set the mode, and the temp hex to set temperature for units that have seperate codes. mode hex codes are optional in the config. Temperature codes will be sent instead assuming these contain the mode information for the AC unit. * Mode change clean-up Separated mode change code from sendTemperature to setTargetHeatingCoolingState to allow it to run when only the mode changes. * Temperature Refresh optimisations iOS13/tvOS13 appears to poll the device status more frequently. Adjusted default temperature update times to reduce duplication. Removed duplicate onTemperature Calls to speed up refresh
ignoreTemperatureWhenOff only applied when off and staying off. This means that when transitioning to off mode, a temperature hexcode was attempted. Now ignores if the target is off, regardless of the current mode.
Removed set temperature from all state updates. Cleaned up targetTemperature refresh to only be on temperature changes.
UI slow on "Updating", changed temperature update frequency of W1 and file updates to 5 minutes instead of 10.
Coded with a minimum of 60 seconds to avoid high unnecessary disk IO - with default value of 10 for this parameter.
w1 devices read straight from the bus, no IO impact so no need to limit refresh interval
* Improved ping error handling Removed exception throw and treated as a non response to allow retries Fixes #45
* Re-enabled additional device temp check
* Fixed device state logic post changes * Improved status handling
* Bug fix when falling back to 'classic mode' Was failing to load temperatureX hexcodes from config. Fixes #60
* Support various new RM Mini devices by updating to the latest broadlinkjs-rm library
* Support for resetting to a default fan speed each time a fan is turned on
"alwaysResetToDefaults": true,
"defaultFanSpeed": 30,
* Support for a “window” accessory that mimic the functionality of a window-covering
* Added support for Air Purifier accessories
* Added default state for lock controls
* Added support for Humidifier/Dehumidifiers
* Garage Door Opener - If the `autoCloseDelay` is set to `0`, set the Homekit state to closed immediately
* Allow for separate commands for turning swing mode/oscillation on/off
* Fixed a potential crash when learning RF data
* Updated packages to resolve potential security issues.
* Improvements to how ping’s work to improve performance and device re-discovery
Temperature would be set to default mode temperature, regardless of request Also fixed UI refresh when turning off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In iOS14, TV accessory appear Home icon. Please check that and update addon.
Thank you and best regards.