Skip to content

Commit

Permalink
Move @types/aws-lambda from devDependencies to dependencies
Browse files Browse the repository at this point in the history
The `@remix-run/architect` package exports types that depend upon
`@types/aws-lambda`, so it needs to depend (not devDepend) on it.

This will fix the following error that occurs on a freshly
bootstrapped Architect project generated with create-remix:

```
$ npm run typecheck

> typecheck
> tsc

node_modules/@remix-run/architect/dist/server.d.ts:3:135 - error TS2307: Cannot find module 'aws-lambda' or its corresponding type declarations.

3 import type { APIGatewayProxyEventHeaders, APIGatewayProxyEventV2, APIGatewayProxyHandlerV2, APIGatewayProxyStructuredResultV2 } from "aws-lambda";
                                                                                                                                        ~~~~~~~~~~~~
```

See https://stackoverflow.com/a/46011417/167694.

Addresses part of remix-run#6296.
  • Loading branch information
lpsinger committed Jun 14, 2023
1 parent 3a7beca commit 218721b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/remix-architect/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
"typings": "dist/index.d.ts",
"dependencies": {
"@architect/functions": "^5.2.0",
"@remix-run/node": "1.17.0"
"@remix-run/node": "1.17.0",
"@types/aws-lambda": "^8.10.82"
},
"devDependencies": {
"@types/aws-lambda": "^8.10.82",
"@types/lambda-tester": "^3.6.1",
"lambda-tester": "^4.0.1"
},
Expand Down

0 comments on commit 218721b

Please sign in to comment.