Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw err when data size too big for largest qr code #12

Merged
merged 5 commits into from
Mar 17, 2019

Conversation

ongspxm
Copy link
Contributor

@ongspxm ongspxm commented Mar 10, 2019

Currently, for input data that exceeds the data size possible for the
qrcode, a blank canvas or image will be returned without any error
thrown.

For applications that uses this library, it might be hard for them to
know that an error occurred in the qrcode generation.

Let's alter the qr code generation process to throw the "code length
overflow" error is thrown after it has tried all the versions of the
qrcode.

@rugk
Copy link

rugk commented Mar 10, 2019

Note: Used for rugk/offline-qr-code#168, as a requirement for rugk/offline-qr-code#72 in the Offline QR Code Generator add-on.

Copy link

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know whether updating package-lock.json is really what @lrsjng wants…

@ongspxm
Copy link
Contributor Author

ongspxm commented Mar 12, 2019

@lrsjng ready for review

@lrsjng lrsjng merged commit de5bdd4 into lrsjng:master Mar 17, 2019
@lrsjng
Copy link
Owner

lrsjng commented Mar 17, 2019

@ongspxm thank you and sorry for the delay!

@ongspxm ongspxm deleted the throwerr branch March 18, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants