Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disappearing versions #112

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

farisd16
Copy link
Member

This PR fixes disappearing versions, a bug that can be reproduced in the following way:

create a new diagram -> create a new version -> edit version -> create a new version -> make a change to the diagram

The bug is fixed by reloading the editor after creating a new version.

@farisd16 farisd16 added the bug Something isn't working label Nov 25, 2024
@farisd16 farisd16 self-assigned this Nov 25, 2024
Copy link
Contributor

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected when testing on the consolidated branch

@FelixTJDietrich FelixTJDietrich merged commit 195ab1c into main Dec 6, 2024
2 of 3 checks passed
@FelixTJDietrich FelixTJDietrich deleted the bugfix/disappearing-versions branch December 6, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants