Development: Move repository from yarn to npm
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/server/package.json # packages/webapp/package.json # yarn.lock
matthiaslehnertum
changed the title
Development: Move repository from yarn to npm
There was a problem hiding this comment.
@matthiaslehnertum I could not find any linting rules that are enforced atm. Is linting completely off?
|
@loreanvictor Could you have another look? I changed the README and ensure quote enforcements. :) |
|
Can we merge this PR? |
There was a problem hiding this comment.
I tested locally on MacOS and had issues building the project due to the canvas module. (Error message below)
After installing the necessary binaries for MacOS with brew (Node-Canvas), building and starting worked fine.
Therefore, I would think about adding the Node-Canvas link to the readme to inform future developers about installing the binaries.
AlexanderG2207
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As as well per Stephan's request, this PR updates all of Apollon Standlone's dependencies to a recent version, replaces yarn by npm as a package manager and replaces tslint with eslint.
At the moment, a lot of the eslint default rules are disabled to have eslint behave the same way as tslint behaved before. In the future, we should sequentially reenable these rules and fix the issues detected. To not make this PR unnecessarily large, I decided to not do this in the current PR.
Motivation and Context
A lot of Apollon Standlone's dependencies, especially tslint, were outdated.
Steps for Testing
The most sensible test for this change would be to test if running and building the application behaves as expected.